Extend wrapped JS function coverage in core runtime types #12263

Atur256 · 2025-09-30T11:32:58Z

This pull request expands the set of host-accessible wrappers for internal JavaScript functions across key runtime types: JSObject, JSNumber, JSString, JSSymbol, and JSValue. These additions improve Java interop and simplify invocation of JavaScript behavior from host code.

Additionally, the class JSError has been renamed to ThrownFromJavaScript to better reflect its actual role. The original name implied alignment with the native JavaScript Error object, but the class more accurately represents any object thrown from JavaScript, regardless of its type.

…ame JSError to ThrownFromJavaScript - Introduced new methods to core JS runtime types to improve host interop - Renamed JSError to ThrownFromJavaScript for semantic clarity - Original name implied alignment with native JS Error, but the class represents any thrown JS object

oracle-contributor-agreement · 2025-09-30T11:33:03Z

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

PR author: Atur256
[email protected] (@Atur256)

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSNumber.java

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java

axel22 · 2025-10-01T12:57:27Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java

+    public static native JSString fromCharCode();
+
+    @JS.Coerce
+    @JS(value = "return String.fromCharCode(...codeUnits);")


Was conversion to a JS array not necessary here?

Conversion wasn’t necessary in this case because primitive arrays are apparently coerced automatically. At least the int array is coerced to a Int32Array in JavaScript in this function.

axel22 · 2025-10-01T13:43:34Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSSymbol.java

+
+    @JS.Coerce
+    @JS(value = "return Symbol.keyFor(sym);")
+    public static native JSValue keyFor(JSSymbol sym);


Does this return a JSString always, so it could return a String here?

It could also return undefined, which is why JSValue is currently used here.

In that case I think we should modify this to return a Java string and null if the JS functions returned undefined

oracle-contributor-agreement · 2025-10-03T08:53:14Z

Thank you for signing the OCA.

patrick96 · 2025-10-07T10:05:02Z

...racle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/testdispatcher/JSAnnotationTests.java

+        } else if (checkClass(JSSymbolTest.class, className)) {
+            JSSymbolTest.main(null);
+        } else if (checkClass(JSObjectTest.class, className)) {
+            JSObjectTest.main(null);


Pass remainingArgs for all these tests, even if the arguments are not used right now. Passing null to the main method is really unexpected

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSNumber.java

patrick96 · 2025-10-07T10:29:05Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSNumber.java

+
+    @JS.Coerce
+    @JS(value = "return parseFloat(number);")
+    public native static float parseFloat(String number);


parseFloat returns JS number, so we should use double here.

Also, we should probably prefer Number.parseFloat (even though they're the same function) just for consistency.

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSNumber.java

patrick96 · 2025-10-07T10:39:43Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSNumber.java

+    public native static int parseInt(String number);
+
+    @JS.Coerce
+    @JS(value = "return parseInt(number, radix);")


Prefer Number.parseInt for consistency

patrick96 · 2025-10-07T12:02:50Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSSymbol.java

+
+    @JS.Coerce
+    @JS(value = "return Symbol.keyFor(sym);")
+    public static native JSValue keyFor(JSSymbol sym);


In that case I think we should modify this to return a Java string and null if the JS functions returned undefined

patrick96 · 2025-10-07T12:05:24Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSSymbol.java

+
+    @JS.Coerce
+    @JS(value = "return sym.valueOf();")
+    public static native JSSymbol valueOf(Object sym);


Why is this method needed?

patrick96 · 2025-10-07T12:07:52Z

web-image/src/com.oracle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/api/JSSymbolTest.java

+        JSSymbol sym = JSSymbol.asyncDispose();
+
+        assertEquals("JavaScript<symbol; Symbol(nodejs.asyncDispose)>", sym.toString());
+        assertEquals(JSSymbol.class, sym.getClass());


This is check is not needed here or in any of the tests below. sym.getClass() is always JSSymbol.class since the type of the variable is JSSymbol, which is a final class

patrick96 · 2025-10-07T12:09:23Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSSymbol.java

+
+    @JS.Coerce
+    @JS(value = "return sym.description;")
+    public static native String description(Object sym);


Why is this not an instance method?

patrick96 · 2025-10-07T12:23:18Z

web-image/src/com.oracle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/api/JSSymbolTest.java

+import static org.junit.Assert.assertNotSame;
+import static org.junit.Assert.assertTrue;
+
+public class JSSymbolTest {


I don't think we need to have tests for any of the well-known symbols. There doesn't seem to be a spec that defines what description or keyFor should produce for them. And just comparing against things like nodejs.asyncDispose ties us to the behavior of a specific node version.

patrick96 · 2025-10-07T13:59:57Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java

+
+    @JS.Coerce
+    @JS(value = "return String.fromCharCode(...codeUnits);")
+    public static native JSString fromCharCode(int... codeUnits);


Could use use char... codeUnits instead here? The function only accepts numbers from 0 to 65535 anyway.

patrick96 · 2025-10-07T14:00:35Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java

+
+    @JS.Coerce
+    @JS(value = "return String.fromCodePoint(...codeUnits);")
+    public static native JSString fromCodePoint(int... codeUnits);


Suggested change

public static native JSString fromCodePoint(int... codeUnits);

public static native JSString fromCodePoint(int... codePoints);

patrick96 · 2025-10-07T14:02:36Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java

+            for (let i = 0; i < substitutions.length; i++) {
+                args.push(substitutions[i]);
+            }
+            return String.raw(template, ...args);


Does ...Array.from(substitutions) work?

patrick96 · 2025-10-07T14:43:57Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java

+
+    @JS.Coerce
+    @JS(value = "return this.localeCompare(compareString, locales, options);")
+    public native int localeCompare(JSString compareString, JSString locales, Object options);


This should be JSObject here and above

patrick96 · 2025-10-07T14:45:35Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSString.java

+
+    @JS.Coerce
+    @JS(value = "return this.match(regexp);")
+    public native JSObject match(Object regexp);


Suggested change

public native JSObject match(Object regexp);

public native JSObject match(JSObject regexp);

patrick96 · 2025-10-07T15:27:19Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSObject.java

+
+    @JS.Coerce
+    @JS(value = "return Object.hasOwn(obj, prop);")
+    public static native boolean hasOwn(JSObject obj, String prop);


Create overloads for JSSymbol and JSString

patrick96 · 2025-10-07T15:32:35Z

sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSObject.java

+
+    @JS.Coerce
+    @JS(value = "return this.propertyIsEnumerable(prop);")
+    public native boolean propertyIsEnumerable(String prop);


Create overloads for JSSymbol and JSString

patrick96 · 2025-10-07T15:40:06Z

web-image/src/com.oracle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/api/JSObjectTest.java

+        try {
+            obj.set("name", "Alice");
+        } catch (Exception e) {
+            failed = true;


Use assertThrows here and in the rest of this class

patrick96 · 2025-10-07T15:42:23Z

web-image/src/com.oracle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/api/JSObjectTest.java

+        }
+        String result = JSValue.checkedCoerce(obj.get("name"), String.class);
+        JSValue fun = (JSValue) obj.get("greet");
+        String greeting = apply(fun, null, "World");


Isn't this the same as in testPrototypeInheritance? If so, this part can be removed from this test

patrick96 · 2025-10-07T15:47:53Z

web-image/src/com.oracle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/api/JSObjectTest.java

+                    for (let i = 0; i < values.length; i++) {
+                        arr.push(values[i]);
+                    }
+                    return arr;


Does return Array.from(values) work here?

oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Sep 30, 2025

fniephaus requested review from axel22 and patrick96 September 30, 2025 13:04

fniephaus assigned patrick96 Sep 30, 2025

axel22 reviewed Oct 1, 2025

View reviewed changes

oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Oct 3, 2025

add tests for JSNumber, JSObject, JSString, JSSymbol

16caca3

patrick96 reviewed Oct 7, 2025

View reviewed changes

	public static native JSString fromCodePoint(int... codeUnits);
	public static native JSString fromCodePoint(int... codePoints);

	public native JSObject match(Object regexp);
	public native JSObject match(JSObject regexp);

Extend wrapped JS function coverage in core runtime types #12263

Are you sure you want to change the base?

Extend wrapped JS function coverage in core runtime types #12263

Conversation

Atur256 commented Sep 30, 2025

Uh oh!

oracle-contributor-agreement bot commented Sep 30, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Atur256 Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oracle-contributor-agreement bot commented Oct 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Atur256 Oct 2, 2025 •

edited

Loading